aMule Bug Tracker - aMule
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001572aMuleMulti Platformpublic2009-12-30 13:112014-09-12 09:55
ReporterDerevko 
Assigned ToGonoszTopi 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version2.2.6 
Target VersionFixed in Version2.3.2 
Fixed in Revision10838
Operating SystemDebian
Summary0001572: [Debian] failed to build on alpha and hppa - wrong fallocate check
DescriptionHi,

aMule 2.2.6 fails to build on alpha and hppa.

Full log: https://buildd.debian.org/fetch.cgi?pkg=amule&arch=alpha&ver=2.2.6%2Bdebian0-2&stamp=1262114500&file=log&as=raw [^]

I had a quick look at config.log, and it seems that fallocate() in alpha works with gcc and doesn't work with g++. Should fallocate() be checked with g++?

Cheers,
Giuseppe.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch fallocate-dev.patch (710) 2010-05-19 21:07
http://bugs.amule.szerverem.hu/file_download.php?file_id=331&type=bug
patch fallocate-2.2.6.patch (662) 2010-05-19 21:07
http://bugs.amule.szerverem.hu/file_download.php?file_id=332&type=bug
Issue History
Date ModifiedUsernameFieldChange
2009-12-30 13:11DerevkoNew Issue
2009-12-30 13:11DerevkoOperating System => Debian
2010-05-19 10:04GonoszTopiNote Added: 0003438
2010-05-19 10:04GonoszTopiAssigned To => GonoszTopi
2010-05-19 10:04GonoszTopiStatusnew => assigned
2010-05-19 10:04GonoszTopiStatusassigned => feedback
2010-05-19 10:23DerevkoNote Added: 0003439
2010-05-19 21:07GonoszTopiFile Added: fallocate-dev.patch
2010-05-19 21:07GonoszTopiFile Added: fallocate-2.2.6.patch
2010-05-19 21:10GonoszTopiNote Added: 0003440
2014-09-12 09:55GonoszTopiFixed in Revision => 10838
2014-09-12 09:55GonoszTopiNote Added: 0003637
2014-09-12 09:55GonoszTopiStatusfeedback => resolved
2014-09-12 09:55GonoszTopiResolutionopen => fixed
2014-09-12 09:55GonoszTopiFixed in Version => 2.3.2

Notes
(0003438)
GonoszTopi   
2010-05-19 10:04   
This seems to be a gcc (or installed headers/libraries) bug, then. Though, your suggestion also makes sense: we use g++ almost always, but for the checks we use gcc (except where a C++ compiler is explicitly needed). Thus the inconsistency between the usage and the test case is real.

However, since I don't have access to an alpha I can't test whether fixing this issue really fixes alpha build (i.e. there are no other functions with the same problem). If you can and will test such a patch, I'll be glad to sort this thing out.
(0003439)
Derevko   
2010-05-19 10:23   
which patch do you refer?

In the Debian package I disabled fallocate() in alpha and hppa:

http://patch-tracker.debian.org/patch/series/view/amule/2.2.6+debian0-7/fallocate.diff [^]
(0003440)
GonoszTopi   
2010-05-19 21:10   
I referred to a theoretical patch that just came into existance. ;)

I made two versions of the patch, one for the 2.2.6 release, the other for a current development snapshot. Please note, that the patch only modifies the autoconf input file configure.in, thus you'll need to run ./autogen.sh (or autoconf at least) after applying.
(0003637)
GonoszTopi   
2014-09-12 09:55   
Applied the patch, and more. Hopefully it doesn't break anything else.